Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove expert mode for stake/unstake/finalize_unstake #280

Merged
merged 3 commits into from
Sep 12, 2024

Conversation

spalmer25
Copy link
Collaborator

fixes #273
stake, unstake and finalize_unstake are usually called with a Unit parameter.
A Unit is not a complex field.
This PR removes the expert-mode requirement when the parsed Micheline is the value Unit.

This PR adds:

  • unit tests for the staking operations. (stake, unstake, finalize_unstake and set_delegate_parameters)
  • display tests for the staking operations.

@spalmer25 spalmer25 added the app::wallet issues relating to the wallet app label Sep 11, 2024
@spalmer25 spalmer25 self-assigned this Sep 11, 2024
@spalmer25 spalmer25 force-pushed the palmer@functori@no-expert-staking-ops branch from 199029c to 724627b Compare September 11, 2024 13:03
@spalmer25 spalmer25 marked this pull request as ready for review September 11, 2024 13:07
@spalmer25 spalmer25 force-pushed the palmer@functori@no-expert-staking-ops branch from 724627b to 9740ebd Compare September 12, 2024 10:06
Operations:
 - stake
 - unstake
 - finalize_unstake
 - set_delegate_parameters
Check:
 - display
 - complexity
@spalmer25 spalmer25 force-pushed the palmer@functori@no-expert-staking-ops branch from 9740ebd to 38e554e Compare September 12, 2024 10:14
Copy link
Collaborator

@ajinkyaraj-23 ajinkyaraj-23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ajinkyaraj-23 ajinkyaraj-23 merged commit 5d9f0d9 into main Sep 12, 2024
138 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app::wallet issues relating to the wallet app
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove expert mode for stake/unstake/finalize
2 participants